fix: allow num_workers=0 by using explicit None check#34
Open
smksyj wants to merge 1 commit into
Open
Conversation
`num_workers=0` is silently ignored because the truthiness check (`if num_workers`) treats `0` as falsy, falling back to `self.config.num_workers` (default `2`). This means passing `num_workers=0` to disable DataLoader multiprocessing has no effect. Replacing the check with `is not None` fixes this, so that `0` is correctly respected while `None` still falls back to the config default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
num_workers=0is silently ignored because the truthiness check (if num_workers) treats0as falsy in python, falling back toself.config.num_workers(default2).This means passing
num_workers=0to disable DataLoader multiprocessing has no effect.Replacing the check with
is not Nonefixes this, so that0is correctly respected whileNonestill falls back to the config default.