Skip to content

Implement proper error state updates in the catch block. #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
annrose2277-glitch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement proper error state updates in the catch block. #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/components/ActivityFeed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ interface EventType {
export default function ActivityFeed({ username }: { username: string }) {
const [events, setEvents] = useState<EventType[]>([]);
const [loading, setLoading] = useState(true);
const [error, setError] = useState<string | null>(null);

// 🕒 time ago function
const getTimeAgo = (dateString: string) => {
Expand All @@ -29,16 +30,26 @@ export default function ActivityFeed({ username }: { username: string }) {
const fetchEvents = async () => {
try {
setLoading(true);
setError(null);

const res = await fetch(
`https://api.github.com/users/${username}/events`
);

if (!res.ok) {
setEvents([]);
setError("Failed to fetch activity");
setLoading(false);
return;
}

const data = await res.json();

setEvents(data);
setEvents(Array.isArray(data) ? data : []);
setLoading(false);
} catch (err) {
} catch (err: any) {
console.error(err);
setError(err.message || "Failed to load activity");
setLoading(false);
}
};
Expand All @@ -57,6 +68,8 @@ export default function ActivityFeed({ username }: { username: string }) {

{loading ? (
<p className="text-center">Loading...</p>
) : error ? (
<p className="text-center text-red-500">{error}</p>
) : events.length === 0 ? (
<p className="text-center">No activity found</p>
) : (
Expand Down
Loading