Skip to content

fix: change logout from GET to POST with session destruction #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mehul-m-prajapati merged 2 commits into from
May 31, 2026
Merged

fix: change logout from GET to POST with session destruction #578

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5fd808
fix: change logout from GET to POST with session destruction
anshul23102 May 27, 2026
36dffdd
Merge branch 'main' into fix/logout-get-to-post-556
mehul-m-prajapati May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions backend/routes/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,33 +217,15 @@ router.post("/login", validateRequest(loginSchema), async (req, res, next) => {
});

// Logout route
router.get("/logout", (req, res) => {

if (!getUseMongoAuth()) {
req.session.destroy((err) => {
if (err) {
return res.status(500).json({ message: 'Logout failed', error: err.message });
}

return res.status(200).json({ message: 'Logged out successfully' });
});

return;
}

router.post("/logout", (req, res) => {
req.logout((err) => {

if (err) {
if (err)
return res.status(500).json({ message: 'Logout failed', error: err.message });
}

req.session.destroy((sessionErr) => {
if (sessionErr) {
return res.status(500).json({ message: 'Logout failed', error: sessionErr.message });
}

req.session.destroy((destroyErr) => {
if (destroyErr)
return res.status(500).json({ message: 'Session cleanup failed', error: destroyErr.message });
res.clearCookie('connect.sid');
return res.status(200).json({ message: 'Logged out successfully' });
res.status(200).json({ message: 'Logged out successfully' });
});
});
});
Expand Down
Loading