Repository navigation
A part clicked in the net pane becomes the selected part (#148) - #149
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
|
Owner
Author
|
Review round 1 (10 findings) Fixed:
Not fixed:
|
The saved part is now cleared by every other selection path, and is only used when the selected part comes off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
A second click on the selected part, in the component list, the net pane or on the board, takes its pin off and selects the part before it again, if that part is still pinned. The three click paths now share clickFootprint, so they behave the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
Wherever the pin comes off (list, net pane, board, or Esc), the net pane detail no longer shows that part. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
Owner
Author
|
Review round 2 (commits 6390e78, dc3ea6d, ac56140; 1 finding) Fixed:
Not fixed (FYI):
Checked and not a bug: one-step give-back and "only if still pinned" are the stated design. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148.
A part clicked in the net pane was shown there, but never became the selected part. The main detail pane, the component list and the address bar kept the part selected before it, so the panes disagreed.
The steps in the issue do not show it, because picking a net clears the selected part. It shows when the net is picked first, then a part X, and then a part Y is clicked in the net pane.
Now:
Only one step back is kept: X › Y › Z, then Z off gives Y, then Y off gives nothing.
Tests: three new tests in
interaction.spec.js. Two of them fail without the fix. Full suite: 163 passed. One known flaky test ("an inner layer checkbox changes both sides") timed out in the full run and passed alone.🤖 Generated with Claude Code
https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK