Skip to content

A second click on a highlighted net or a pinned part takes it off (#133) - #147

Merged
Gherkin merged 2 commits into
mainfrom
deselect-by-clicking-again
Oct 27, 2026
Merged

Gherkin merged 2 commits into
mainfrom
deselect-by-clicking-again

Conversation

@Gherkin

@Gherkin Gherkin commented Oct 27, 2026

Copy link
Copy Markdown
Owner

Closes #133.

A second click on a highlighted net or a pinned part now takes only that item off.

Nets:

  • A click on a highlighted net, on the board or in the net search list, removes it from the walk, the breadcrumbs and the palette.
  • If it was the current net, the net pane goes back to the search list and no net is selected.
  • Breadcrumbs, the → walk links and pad net links still only select.

Parts:

  • A second click already took the pin off. The part stayed selected, with its detail pane open and its row marked. Now the selection goes too, from the board, the component list and the net pane.

Tests:

  • The Selecting the current net again clears the other walked nets from the board #38 test kept checking that a net list click on the current net keeps the highlights. That half is gone, since that click now takes the net off. The breadcrumb half stays.
  • New tests for the net list, a board net click, a board part click and a part row click. All four fail on main.
  • Full suite: 159 passed, 1 timeout in an inner layer checkbox changes both sides. It passes run alone. This is the known flaky test.

🤖 Generated with Claude Code

https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-27 21:37 UTC

A › B › A without B gave A › A in the breadcrumbs and the highlighted
path. pushWalkStep never adds a step that repeats the one before it, so
deselectNet now drops such a step too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
@Gherkin

Gherkin commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

/prr round 1

  • web/app.js:1300 deselectNet can leave a repeated step: walk A › B › A (breadcrumb click on A), then take B off, gives A › A in the breadcrumbs and highlightedNetPath. pushWalkStep never allows that. Fixed: drop a step that repeats the one before it. Test added; it fails on the PR head.

FYI (not fixed)

  • web/app.js:961 In the net pane, unpinning a part closes the detail pane even when a different part is the selected one. Net pane rows have never set selectedFootprintIdx, so this is older than this PR. Choosing what the pane should show then is a separate decision.
  • web/app.js:1300 Taking a net off leaves the part steps next to it, e.g. A › X › B without B is A › X. Not wrong, just a leftover crumb.

@Gherkin
Gherkin merged commit 30dce04 into main Oct 27, 2026
10 checks passed
@Gherkin
Gherkin deleted the deselect-by-clicking-again branch October 27, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a way of deselecting items

1 participant