Repository navigation
Layer table All boxes are three-state, with an All layers row (#136) - #145
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
|
Owner
Author
|
PR review, round 1
No other findings. |
A ticked kind now turns a layer on, so overlay=silk on a link with no x-ray turned the far side on with silk only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136.
What changes
Mixed click
The issue asked what a click on a mixed box usually does. Most tri-state checkboxes (file managers, mail clients, tree views) turn everything on. That is also what the S, O and X style toggles here already did. This PR does the same.
Side effects of dropping the separate All flag
netcopper=NAME:LETTERSin older links is still read; the letters are ignored. README and util.js say so.allflag are migrated: a layer that was off has every kind off, a layer that was on keeps its kinds (or gets all of them if none was ticked).__pcbaTest.versionis 3.state().layers[l].allis now whether the layer is on.Tests
allflag.npm run test:apipasses.🤖 Generated with Claude Code
https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK