Repository navigation
A net's layers include the layers it has pads on (#140) - #144
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
|
Owner
Author
|
Review round 1.
FYI, not fixed:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140.
netToLayerswas built from tracks and zones only. A net with only pads on a layer, for example SMD pads on B and no track there, did not list that layer. SoTandAwith a net selected did not tick it, andnetlayers=1did not turn it on.Pads are now added to the index too. The index now means "the net touches this layer" everywhere it is used:
TandAwith a net selectednetlayers=1in a linknetLayersin the test APIPads are stored on F and B only, so inner layers are not affected. The F and B filters in the net list now match most nets.
The README and the
linktool description now say "tracks, zones or pads" instead of "routed on".Tests: one each for the index,
Tandnetlayers=1, using a fixture net that has pads on B and no copper there.npm run test:api, the browser suite and the MCP tests pass. The full browser run had one timeout inan inner layer checkbox changes both sides, a known flaky test; it passes when run alone.🤖 Generated with Claude Code
https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK