Repository navigation
Z fits a part as it is drawn, turned by its angle and the board (#142) - #143
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
Contributor
|
Owner
Author
|
Review round 1. No correctness findings. Open decision:
FYI:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #142.
zoomToFootprintnow callszoomFitPointswithfootprintCorners(fp). The fit then uses the part's box as it is drawn: turned by the part's angle and by the board rotation. The centre is also right now. The old code took the centre from the unturned box.The copy of the fit math in
zoomToFootprintis gone. A single part now gets the same zoom limit as E: 200 instead of 50.Tests
fit.spec.jsgets four Z tests: a part turned 90° and an unturned long part, each with the board at 0° and 90°. Each checks that the view holds the part with the 8 mm margin, is tight on one axis, and is centred on the part.With the old code, three of the four fail:
Full browser suite: 150 passed. The one failure was the known flaky timeout in
interaction.spec.js("an inner layer checkbox changes both sides"). It passed when run alone.npm run test:apipasses.Not checked in a real browser by hand.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK