Repository navigation
E fits the highlighted nets as the layer table draws them (#137, #138, #139) - #141
Merged
Merged
Conversation
…#139) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
Contributor
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
Owner
Author
|
Review, round 1 — 1 finding.
Fix pushed: Checked and fine: pad/track/via/zone rules match |
The link applied its zoom before the worker's ready message, so E had no zone boxes yet and left zones out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK
Owner
Author
|
Review, round 2 (61264d6 only) — 2 findings, both FYI, not fixed.
Checked and fine: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137, closes #138, closes #139.
E(andzoom=selected) now fits the highlighted nets as they are drawn. It uses the layer table the same way the drawing does.netCopperShows(l, kind)inapp.js. A net's copper on a layer counts when the layer is on, or when it is off with "Net" ticked. Only the kinds ticked on that row count (tracks, zones, vias, pads).Ejudges each one by that check. It no longer counts inner tracks just because the view is F, and no longer drops the far side or the inner layers on the back view.readymessage. The page cannot load the worker's code, so this avoids a second copy of the SVG path parser.footprintCorners(fp)inrender.js.The fit code moved out of
zoomFitSelectedintofitPoints(side), so the tests can read it.Tests
tests/browser/fit.spec.js: an inner layer off/on/Net-only, the side in view off, the far side with Net, an inner layer seen from the back, zones with zones on and off, a pinned part at 90°, andEpressed end to end. It uses three nets from the netdaq fixture whose copper reaches outside their copper on F. A check in the file confirms they still do.npx playwright test: 145 passed, 1 timed out ("an inner layer checkbox changes both sides"). This is the known flaky test. It passed 3 of 3 when run alone.npm run test:api: OK.🤖 Generated with Claude Code
https://claude.ai/code/session_01UCbPYsA5LYNX8HZaGGZCpK