Repository navigation
Agent skill for the viewer MCP tools (#14) - #105
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FzHC7LspikUyimHw5ptN8x
|
Owner
Author
|
Review round 1 ( Findings:
Not fixing:
Checked, no issue: frontmatter ( |
- Any snapshot error: give the link and say it was not checked. - Focus the pad's own part, not the near part; frame a via with a view. - A net with no pads: leave it out of nets and keep the via marker. - Through-hole side: trust the side field. - Look for the tools by name, not by server name. - A generic rail-name example instead of one board. - Vias are "often" covered, as the tool says; fix the list formatting. - README: the link is an alternative to the copy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FzHC7LspikUyimHw5ptN8x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14. Part of #73.
Adds
skills/pcb-viewer/SKILL.md, a Claude Code skill that tells an agent how to use the viewer MCP tools, and a README section on how to install it.The skill says to:
+3.3Von netdaq); match pads toREFDES:PINwithpinwhere the board has it;nearestfirst; readtestpoint,type,own,covered_by,sideanddistanceas the tools define them; prefer a test point or through-hole pad when it is about as close;nearest_viasonly when no usable pad is near, and say a via is a last resort and likely under soldermask;link, with a marker on a single pad or via; ask for the board list address whenlinkwarns that none is set;snapshotwhen it matters.Format checked against https://code.claude.com/docs/en/skills: folder with
SKILL.md, YAML frontmatter withnameanddescription, description says when to use it, body well under 500 lines.End-to-end test: static site built from
tests/fixtures/netdaq-small.json, server in stdio mode, an MCP client script, and the netlist MCP. Question: "Is there a point where I can patch +3.3V close to U24?" Netlist: U24:4 (V+) is on+3.3V.nearestgave U24 pad 4 (own, SMD, TSSOP lead, F) at 0; the next pads on the trimmed board are 43 mm away.nearest_viashas a through via 0.85 mm away.linkwith a marker on U24:4 and focus on U24;snapshotshowed the marker on pin 4. Testing showed thatzoom: "selected"with+3.3Vselected zooms out to most of the board, so the skill now says to focus the part instead.Tests: mcp
npm testpasses (HTTP and stdio). Playwright: 105 passed, 1 failed (interaction.spec.js"an inner layer checkbox changes both sides", the known flake); that file alone then passed 46/46.🤖 Generated with Claude Code
https://claude.ai/code/session_01FzHC7LspikUyimHw5ptN8x