-
Notifications
You must be signed in to change notification settings - Fork 14
Match chat test parity codegen #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
daksh-r
wants to merge
15
commits into
cha-1578_openapi-refactor-codegen
Choose a base branch
from
match-chat-test-parity-codegen
base: cha-1578_openapi-refactor-codegen
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d635d5a
feat: add chat test parity with stream-chat-python
41a813f
chore: regenerate SDK from latest OpenAPI spec
84f7c26
fix: fix test failures to match actual API responses
61e4d48
fix: correct skip reasons after investigating backend behavior
064c70e
fix: fix test_delete_message_for_me - add user as channel member
bc791a0
fix: fix test_query_message_flags to match getstream-go approach
9689bd2
feat: match chat test parity with getstream-go and split CI credentials
f195524
fix: add STREAM_CHAT_BASE_URL for non-video CI tests
c16166e
fix: properly separate video and non-video tests in CI
3c0ac3d
fix: fix test_delete_channels timeout and wait_for_task
77c45ff
style: fix ruff formatting in tests/base.py
c895a8e
refactor: reorganize test_chat_channel.py per code review feedback
e1c88c8
fix: address code review feedback in test_chat_message and test_chat_…
f55b775
fix: extract command names as strings when restoring channel type config
ead8884
test: add missing chat tests for parity with stream-chat-python
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| hello world test file content |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait_for_task silently returns on task failure
Low Severity
wait_for_tasknow returns successfully whenstatusis"failed", treating it the same as"completed". While current callers happen to assertstatus == "completed"afterward, any future caller that simply uses the return value without checking the status will silently accept a failed task. The function name and docstring imply it waits for successful completion, creating a subtle contract mismatch.