Repository navigation
docs: name both registries the template publishes to - #32
Merged
Merged
Conversation
The README mentioned only GHCR, but docker-publish.yml pushes to Docker Hub as well. Keeps the `<module-name>` placeholder, since it is the template, and points at the `IMAGE_NAME` that controls it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README mentioned only GHCR, but
docker-publish.ymlhas always pushed to Docker Hub as well — so a new module scaffolded from this template inherits a README that undersells where its image lands.Keeps the
<module-name>placeholder, since this is the template and the name is genuinely per-module, and points at theIMAGE_NAMEenv that controls it.Worth knowing for anyone scaffolding from here: new GHCR packages are created private by default, so the GHCR line only works after flipping the package to public in its settings. The Docker Hub push is public from the first release.