Repository navigation
v3.6.3 - #179
Merged
Merged
v3.6.3#179
Conversation
Rafnuss
changed the title
Rafnuss
marked this pull request as draft
October 7, 2026 08:25
Rafnuss
changed the title
…tion Drift stretches hourly pressure intervals slightly above 3600 s, which tripped the 1-hour resolution check in geopressure_map_preprocess(). In ts2mat(), drift-corrected samples slide against the exact day-dividing grid, so sensors coarser than twice twl_time_tolerance (e.g. 10-min light) lost up to a third of their values and twilights. Allow half a grid step when matching. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A misspelled sensor (e.g. presure) was silently ignored, leaving that sensor uncorrected. Names are now checked against the sensors tag_create() can read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeoPressureR v3.6.3
Main
Fix wind movement models in
geopressuretemplate()by keeping the recordedpressure_sourcevalue out of the wind function arguments.Validate graph outputs and simulation count after applying direct template parameter overrides.
Use
path_simulationwhen creating simulation pressure paths ingeopressuretemplate().Add sensor clock drift correction to
tag_create(), alongsidetime_shift(hours):time_driftis in hours per 365.25-day year, with positive values adding time. Both accept a scalar for all sensors or a named list; omitted sensors receive zero correction.time_referencedefaults to the earliest original measurement across all sensors, or accepts an explicit UTC timestamp. Corrections use original timestamps and a shared reference, independently of recording duration, before cropping (#177).Round all sensor timestamps to milliseconds after correction and before cropping, including when no correction is supplied. Warn when rounding creates new duplicate timestamps, even with
quiet = TRUE, while retaining all measurements. Timestamp-based labels cannot distinguish colliding readings.Preserve millisecond timestamps throughout label files, TRAINSET saves, downloads, backups and chart selections, light grids and measured/astronomical twilights. Restore original measurement timestamps before joining pressure API responses that truncate times to whole seconds; stop on ambiguous incomplete responses. Keep exact label matching, tolerate millisecond rounding in sampling checks, and use complete daily light grids and whole-hour pressure grids. Rerun analysis from original raw data and regenerate timestamp-dependent labels when changing clock corrections.
Breaking change: rename the
geolight_map()argument and stored configuration keyrefine_fitted_location_scale_kmtorefine_fitted_location_scale. Update scripts, configuration files andparam$geolight_map; the old name is no longer accepted. Units remain kilometres and the default remains 20. Internalscale_km,radius_lat_kmandradius_lon_kmlikewise becomescale,radius_latandradius_lon.Minor
Keep TRAINSET measurement and elevation-proposal charts on date axes, preserving millisecond timestamps while displaying readable automatic date/time ticks at each zoom level.
Add fast, offline regression tests for template parameter handling, output selection and ARCO processing, and ARCO chunk reuse.
Reorganize
tag_create()help into workflow, sensor files, tabular input, clock correction and cropping sections.Document the argument naming convention in
AGENTS.md: public and internal argument names omit unit suffixes; parameter documentation states fixed units and duration conventions for rates.Add regression tests for corrections, millisecond rounding and collisions, label round trips, TRAINSET saves and selections, twilights, API joins and processing grids. Validate the supplied 29JH data (21,272 pressure readings) with zero and ±12 minutes/year drift and live API queries. The full test suite passes with one existing wind-test skip and one unrelated API altitude warning; formatting and lint checks pass.
Full Changelog: v3.6.2...v3.6.3