Repository navigation
v1.3.1 - #44
Merged
Merged
v1.3.1#44
Conversation
- The default column selection listed LongitudeRemoved and LongitudeAttached twice and omitted LatitudeRemoved, so read_soi() wrote retrieval observations without latitude. - A character filter_col selected a column literally named "filter_col" and always failed; it now selects the given columns. - Data frames passed as data_file or order_file no longer fail the input check. - Read 99999 coordinates (unknown in the SOI database) as NA. - Read AccSamplingRate and PriorityMemory as numbers and PrioritySensor as text instead of logical. - Warn with the tag and error when read_soi() cannot read a tag instead of dropping its measurements silently. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mdb-export wrote dates as MM/DD/YY HH:MM:SS, which readr parsed as NA, so every date read from the Access file on macOS/Linux was missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jarl 0.7.0 adds the undesirable_operator rule, which bans <<- by default and fails CI on existing code. Keep ::: and ->> banned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The export needs an Access file and mdb-export or the Access ODBC driver, which CI does not have. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rafnuss
marked this pull request as ready for review
October 21, 2026 17:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeoLocatoR v1.3.1
Main
read_soi_gld(). The default column selection (filter_col = TRUE) listedLongitudeRemovedandLongitudeAttachedtwice and omittedLatitudeRemoved, so every retrieval observation created byread_soi()had no latitude. Packages created from SOI data with earlier versions should be recreated, or their retrieval latitudes filled. Coordinates recorded as99999(unknown in the SOI database) are now read as missing instead of being written as observations.read_soi_gld()on macOS and Linux.mdb-exportwrote them asMM/DD/YY HH:MM:SS, which was parsed asNA, so every date (attachment, retrieval, RTC, first and last data, delivery) was missing andread_soi()created equipment and retrieval observations without a datetime. They are now exported in ISO format. Packages created from an Access file on these systems with earlier versions should be recreated.Minor
filter_colinread_soi_gld(), which previously always failed, and accept data frames fordata_fileandorder_fileas documented.AccSamplingRate,PrioritySensorandPriorityMemorywith their actual types (number, text and percentage) instead of logical, which turned their values intoNA.read_soi()cannot read the data of a tag, naming the tag and the error, instead of silently leaving its measurements out.Full Changelog: v1.3.0...v1.3.1