Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
# Conflicts: # DESCRIPTION
GeoLocatoR already discarded these columns under the GeoLocator-DP fieldsMatch rule. The warnings started when adad0b1 made discarded columns visible, rather than because the schema newly prohibited them. Remove the known GeoPressureR columns explicitly during template conversion, retain warnings for unexpected columns, and cover the conversion in the importer regression test. Document that resource data are unchanged and interim files need no rerun.
Restrict the explicit parser specifications for tags.csv and observations.csv to their headers so absent optional columns no longer cause unmatched-parser warnings. Keep declared types for present fields and retain parsing warnings for invalid values. Add regression coverage for sparse metadata tables, leading-zero identifiers, text and numeric types, UTC timestamps, missing values, and invalid numeric input. Document the CSV import behavior in NEWS.
Regenerate gldp_to_dwc help from its existing source so the scientific_name_ids argument and current Darwin Core mapping are documented. Render the internal gldp_profile_schema name as code rather than a link to a nonexistent help topic. Replace deprecated .data selections in gldp_to_tag with column names and assert the existing conversion runs without warnings. The suite reports 567 passes, zero failures and warnings, and three skips; R CMD check reports zero errors, warnings and notes.
Add the missing datapackage_id CSV parser so an entirely empty column remains character instead of being inferred as logical and rejected by validate_gldp(). Cover the empty-column case in the template import regression test and document the fix in NEWS.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.