Repository navigation
benchmark: add Figanos comparison and reference-figure regression - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a reproducible Figanos 0.7.0 benchmark, closes concrete layout/fidelity gaps, and adds source-backed reference-figure regression.
Cross-library benchmark
temp_div;Figanos remains stronger for general-purpose climate plotting and Xarray-native faceting. In the current SSP benchmark, Figanos matches the WGI-2022 colours exactly; its SSP1-1.9 / SSP1-2.6 end labels overlap, while the collision-aware ar6-sciplot labels do not.
Plotting/API changes
map_panel_grid()for fixed-size multi-panel maps;add_uncertainty_legend()for agreement, missing-data, and significance encodings;label_line_ends()with vertical collision avoidance;Official colormap provenance
The asset manifest is pinned to
IPCC-WG1/colormaps@b7d3849d4fa521d2583b91360e875e38f191d209.The benchmark workflow verifies all 43 official RGB assets by Git blob SHA. Verified Matplotlib colormaps carry source commit/blob metadata, and the strict map audit checks that metadata rather than accepting an
ipcc_*name alone.Reference-figure regression
Three representative source-backed reproductions now have structured contracts:
The existing committed PNG regression remains in place for all four gallery figures. The workflow now also emits image-difference metrics: exact pixel size, mean absolute error, changed-pixel fraction, and 64 x 64 thumbnail error.
Current reference-regression run:
https://github.com/GeoGeekLab/ipcc-wg1-scientific-plotting-skill/actions/runs/35834845182
All four regenerated PNGs match their committed baselines exactly:
Artifact digest:
sha256:4ea586a8e23bf1aaa05207d6896081cf771bae144f448cb6235b8b80ad7e4878Current head:
f2a6ad407ff9bbbd4df7d35f45372bbc7b11f194Ordinary CI also passes on the same head:
https://github.com/GeoGeekLab/ipcc-wg1-scientific-plotting-skill/actions/runs/35834845231