Repository navigation
Conversation
The integration steps deactivate the env before building DynEarthSol, "Use system compiler". The env has no compilers, so g++ is the system one either way, and DynEarthSol's make -n -B ndims=3 usemmg=1 usegospl=1 gives the same compile and link commands with gospl active and with conda cleared: its Makefile reaches GoSPL's Python through CONDA_ENV_PATH. Building gospl_extensions itself still needs the env. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Step 4 of the DynEarthSol integration deactivates the gospl env before building DynEarthSol, to "use system compiler". That isn't needed: the env has no compilers, and DynEarthSol's
make -n -B ndims=3 usemmg=1 usegospl=1gives identical compile and link commands with gospl active and with conda cleared. Its Makefile finds GoSPL's Python throughCONDA_ENV_PATH, not through activation.What
conda deactivateline from step 4. Building gospl_extensions itself (step 2) still activates the env.DynEarthSol's READMEs get the same change in GeoFLAC/DynEarthSol#112.
AI disclosure
Claude Code (Claude Opus 5.5) checked the build commands and wrote this change and description; I reviewed it.
🤖 Generated with Claude Code