Repository navigation
Review DynEarthSol #112 for doc updates: fix: the GoSPL coupling after any remesh uses the instantaneous velocity #104
Description
GeoFLAC/DynEarthSol#112 merged — fix: the GoSPL coupling after any remesh uses the instantaneous velocity
Why
A GoSPL-coupled run of
gospl_driver/examples/gaussian-weakzone-3d-with-gospl.cfgafter #95 grew small irregular bumps along the scarp between frames 6 and 7: GoSPL's max elevation jumped from 1472 m to 3950 m, while DES's surface only reached 1846 m.The cause is the time-averaged velocity sent to GoSPL. It's each top node's displacement since the last coupling over the interval, and it falls back to the instantaneous velocity only when the surface node count changed. But every remesh renumbers the nodes (
renumbering_meshsorts by x + 1e-3 y + 1e-6 z), so after a remesh that keeps the count,top_nodes[i]can name another node. Re-sorting the saved top nodes reassigns hundreds of them to nodes ~25 km away, which comes out as up to ~480 m/yr instead of 0.015-0.05 m/yr. Thegospl_driver/README.mdcaveat already warned about this.What
Files changed
CHANGELOG.mdREADME.mdbc.cxxgospl_driver/README.md
Next step
Ask Claude Code to run the doc-sync procedure from CLAUDE.md against this PR.
Activity
echoi commentedon Nov 2, 2026
DynEarthSol #112 just merged, but the docs already cover it exactly: it was documented in des3d#95 (commit d0b335b) while #112 was still open for review, and nothing changed in the PR between then and merge. Verified the log line wording (
GoSPL: instantaneous velocity at t=... yr: remeshed since the last coupling (surface nodes N0 -> N1[, same count])) and the build-instructions wording in docs/tutorial/couplinggospl.md both match the final merged PR body verbatim. No doc changes needed.