Implement liftover requests#105
Conversation
…ponse' possibly being unbound
… client implementation
…tax for mapping endpoint
|
Was curious about this after reading weekly report out. Took a quick glance and it looks like there's still some todos left in the source code. Do you plan to address in this PR? |
jsstevenson
left a comment
jsstevenson
left a comment
There was a problem hiding this comment.
I am not sure I'm done reading through this, but I gotta go home so I wanted to just put in what I have now and I'll circle back
| ) | ||
|
|
||
| for caf in cafs: | ||
| if isinstance(caf.focusAllele, iriReference): |
There was a problem hiding this comment.
is this necessary? it should always be one type, right?
There was a problem hiding this comment.
This was part of the original get_caf function. I don't think we prevent people from submitting Alleles with iriReferences, so I think we need this to make sure we catch any of those?
There was a problem hiding this comment.
Ah interesting. I think these come directly from storage so they should always be IRIs, but if it's not new code then probably not worth figuring out
…des instead of restraining it to one
…lidate_allele' already does that
Welp no @korikuzma I totally forgot about the TODOs! I'll resolve them now |
3 participants
closes #104