Update the issue template for bumping GMT version - #4806
Merged
Conversation
seisman
commented
Aug 9, 2026
| - [ ] Run `grep -r "# TODO(GMT.*)" --include="*.py" .` to find TODO items related to GMT | ||
| - [ ] Remove related workarounds/patches | ||
| - [ ] Fix tests with pytest `xfail`/`skipif` markers that now pass | ||
| - [ ] Update URLs to manually inserted images of the GMT documentation |
Member
Author
There was a problem hiding this comment.
According to this checklist, we should update URLs like https://docs.generic-mapping-tools.org/6.6/_images/GMT_coverlogo.png to https://docs.generic-mapping-tools.org/6.7/_images/GMT_coverlogo.png. But I feel it's not necessary, as long as the images exist. So removing it.
Member
There was a problem hiding this comment.
Hm, not sure. If these images do not change over time.
$ grep -r "https://docs.generic-mapping-tools.org/6.6" *
examples/projections/cyl/cyl_universal_transverse_mercator.py:.. figure:: https://docs.generic-mapping-tools.org/6.6/_images/GMT_utm_zones.png
pygmt/encodings.py:- GMT documentation: https://docs.generic-mapping-tools.org/6.6/reference/octal-codes.html
pygmt/params/pattern.py: .. figure:: https://docs.generic-mapping-tools.org/6.6/_images/GMT_App_E.png
pygmt/params/position.py: .. figure:: https://docs.generic-mapping-tools.org/6.6/_images/GMT_anchor.png
pygmt/src/logo.py: .. figure:: https://docs.generic-mapping-tools.org/6.6/_images/GMT_coverlogo.png
pygmt/src/nearneighbor.py: .. figure:: https://docs.generic-mapping-tools.org/6.6/_images/GMT_nearneighbor.png
pygmt/tests/test_text.py: https://docs.generic-mapping-tools.org/6.6/gallery/ex23.html
Member
Author
There was a problem hiding this comment.
It's unlikely any of these images will change over time.
Member
Author
There was a problem hiding this comment.
I've reverted the change in this PR and updated the URLs in #4814.
seisman
added
maintenance
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
yvonnefroehlich
approved these changes
Aug 11, 2026
seisman
removed
the
final review call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4801.