Repository navigation
ci(guard): split unit-tests into three shards so it stops hitting its 10-minute limit - #351
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard's
unit-testsjob runs everytests/test_*file in one job with a 10-minute limit. On main it now takes 9m17s to 9m54s, and it was cancelled at the limit on 97aa0f1 and on #345's head, soci-okfailed for reasons unrelated to the change under test.The job now runs as three shards. File i in the sorted glob runs in shard i mod 3, so every file runs in exactly one shard, and a new test file still needs no workflow edit. Each shard keeps the two planted-failure controls and prints how many of the files it ran.
ci-okstill listsunit-testsinneeds; a matrix job reports failure there if any shard fails, and the ruleset requires onlyci-ok.Checked locally by running the loop with stubbed interpreters: the three shards hold 37 files each, their union is the full list of 111 with no duplicates, and a mutated shard expression fails the same check.
The first sharded run also hit a known flake: in
tests/test_owngenome_live_family.py, a headless Chrome never answered its first DevTools call (Target.createTarget: no answer in 30 s). The same error failed Guard runs 42609845049 and 42082898427 on earlier PRs. The test helper now kills that Chrome and starts a fresh one, up to three times. Checked locally with a fake Chrome that hangs on its first start and runs the real one after that: the helper on main raisesno answer in 30 s, while the new one retries once and evaluates1+1to 2.