Repository navigation
fix(advise): use both advisors inside a subagent when it can start one - #29
Merged
Merged
Conversation
The skill and the README said a subagent cannot start another subagent, so the skill always skipped the Fable advisor there. Claude Code lets a subagent start its own subagents up to three layers deep, and withholds the Agent tool only at that limit or when the definition leaves it out. Inside a subagent the skill now dispatches the Fable advisor when it has the Agent tool, and runs Codex alone only when it does not. It still never uses AskUserQuestion there, and hands any disagreement back to the parent. Closes #28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28
Why
The README and the
adviseskill said "a subagent cannot start another subagent", so inside a subagent the skill always skipped the Fable advisor and ran Codex alone. That is wrong. The Claude Code docs say: "By default, a subagent can spawn subagents of its own, up to three layers below the main conversation." TheAgenttool is withheld only at that limit, or when the subagent's definition leaves it out.Changes
skills/advise/SKILL.md: inside a subagent, the skill dispatches the Fable advisor as usual when it has theAgenttool. It runs Codex alone, and reports Fable as skipped, only when it does not.README.md: the paragraph under the subagent example says the same.Unchanged: the skill never uses
AskUserQuestioninside a subagent, which the docs confirm is removed from every subagent, and it hands any disagreement back to the parent. The ask-first rule is untouched.Verification
claude plugin validate . --strictpassespytest: 50 passed