Add NullAway static null-safety checker via Error Prone#9
Merged
Conversation
- Added Error Prone 2.45.0 as compiler plugin - Added NullAway 0.12.14 for null-safety checking - Added JSpecify 1.0.0 for nullability annotations - Configured Error Prone with Java 21 compatibility flags - Fixed nullability issues in PrintAll.java - Added @SuppressWarnings for test helper classes - All tests passing Co-authored-by: Garciat <118277+Garciat@users.noreply.github.com>
Garciat
reviewed
Dec 14, 2025
Garciat
reviewed
Dec 14, 2025
Copilot
AI
changed the title
[WIP] Add NullAway support via Error Prone
Add NullAway static null-safety checker via Error Prone
Dec 14, 2025
- Created new Unit record type in types package - Updated PrintAll to use Unit instead of Void with @nullable - Removed @SuppressWarnings annotation as it's no longer needed - Updated test to use Unit type - All tests passing Co-authored-by: Garciat <118277+Garciat@users.noreply.github.com>
Owner
|
@copilot how come the check didn't trigger for |
Contributor
Author
NullAway didn't trigger for
This is actually a good candidate for using |
Owner
|
@copilot yes let's use Unit there as well. |
- Updated FwdList#forEach to use Unit instead of Void - Replaced null returns with unit() calls - Added static import for Unit.unit() - Eliminates all null usage from FwdList#forEach - All tests passing Co-authored-by: Garciat <118277+Garciat@users.noreply.github.com>
Contributor
Author
Garciat
approved these changes
Dec 14, 2025
Copilot stopped work on behalf of
Garciat due to an error
December 14, 2025 12:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.