Implement Java Compiler Plugin for witness resolution verification#16
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
============================================
+ Coverage 66.49% 66.87% +0.38%
- Complexity 224 289 +65
============================================
Files 47 54 +7
Lines 567 818 +251
Branches 42 77 +35
============================================
+ Hits 377 547 +170
- Misses 168 223 +55
- Partials 22 48 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5070273 to
d0c16a0
Compare
dfb45f3 to
29e125e
Compare
29e125e to
3204e4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now I have duplicated the resolution implementation. I tried having a unified implementation but I got stuck modeling the types so they fit both worlds. That remains a task for future work.
I also dropped support for context instances in the checker.
Fixes #14