Skip to content

APIS-6645: resolve bugs and typos in transformSchema - #162

Merged
praveenp1469 merged 1 commit into
masterfrom
APIS-6645
Sep 21, 2026
Merged

praveenp1469 merged 1 commit into
masterfrom
APIS-6645

Conversation

@praveenp1469

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates transformSchema.json by adding type to the required properties of the current time schema, specifying the type for the format property, fixing a typo in a description, and renaming the format property to delimiter. Feedback highlights a potential schema validation issue where the required array preceding the renamed delimiter property likely still references the old format property and needs to be updated.

Comment thread transformSchema.json
"additionalProperties": false,
"properties": {
"format": {
"delimiter": {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The property name has been changed from format to delimiter to match the Go implementation for toCamelCase. However, the required array immediately preceding this block (ending on line 344) likely still lists format as a required property. If so, this will cause schema validation to fail because format is no longer defined and additionalProperties is set to false. Please update the required array to require delimiter instead of format.

@orca-security-us orca-security-us Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 32.634%. remained the same — APIS-6645 into master

@praveenp1469
praveenp1469 merged commit 172ea8e into master Sep 21, 2026
6 checks passed
@praveenp1469
praveenp1469 deleted the APIS-6645 branch September 21, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants