Skip to content

Use newer 'msgp' package version. - #161

Merged
gannett-ggreer merged 2 commits into
masterfrom
APIS-8813-msgp
Aug 28, 2026
Merged

gannett-ggreer merged 2 commits into
masterfrom
APIS-8813-msgp

Conversation

@gannett-ggreer

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the msgp dependency to v1.6.4-gannett and regenerates the MessagePack serialization files, which now include improved error wrapping via msgp.WrapError and support for a new Nested_to_primitive struct. Additionally, //go:generate directives were added inside generate_test.go. A review comment suggests moving these directives to the top of the file unindented to allow go generate to run seamlessly without requiring manual whitespace adjustments.

Comment thread generate/generate_test.go

@orca-security-us orca-security-us Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 32.634% (-0.7%) from 33.288% — APIS-8813-msgp into master

@gannett-ggreer
gannett-ggreer merged commit 79e63aa into master Aug 28, 2026
7 checks passed
@gannett-ggreer
gannett-ggreer deleted the APIS-8813-msgp branch August 28, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants