Skip to content

APIS-8813 - Linter fixes. - #160

Merged
gannett-ggreer merged 13 commits into
masterfrom
APIS-8813
Aug 28, 2026
Merged

gannett-ggreer merged 13 commits into
masterfrom
APIS-8813

Conversation

@gannett-ggreer

@gannett-ggreer gannett-ggreer commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

@gannett-ggreer gannett-ggreer changed the title APIS-8813 - Linter Fixes. APIS-8813 - Linter fixes. Aug 21, 2026

@orca-security-us orca-security-us Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a .golangci.yaml configuration file to enable comprehensive linting, refactors code to use any instead of interface{}, and updates error formatting to use %w for proper error wrapping. Additionally, test files are updated to utilize subtests (t.Run) with proper cleanup, and various minor code simplifications are made. Feedback on the changes highlights potential runtime panics due to unsafe type assertions in transform/transformer.go and suggests consolidating multiple declarations of var err error in jsonschema/reference.go to prevent shadowing.

Comment thread transform/transformer.go
Comment thread transform/transformer.go
Comment thread jsonschema/reference.go
@coveralls

coveralls commented Aug 21, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 33.288% (-0.5%) from 33.814% — APIS-8813 into master

@gannett-ggreer
gannett-ggreer force-pushed the APIS-8813 branch 5 times, most recently from 1aa118e to 744b2c6 Compare August 24, 2026 20:26
@gannett-ggreer
gannett-ggreer merged commit 4f98750 into master Aug 28, 2026
7 checks passed
@gannett-ggreer
gannett-ggreer deleted the APIS-8813 branch August 28, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants