Repository navigation
fix(valheim): readiness probed /status — the image serves /status.json - #22
Merged
Merged
Conversation
The readiness probe GET /status returned 404 forever: lloesche/valheim-server serves its status endpoint at /status.json. Observed on the test cluster — the server was healthy with the world loaded for 3h50m while the probe failed 1008 times, so Valheim would never be marked Ready. That matters beyond cosmetics: readiness gates the graceful-stop wait and anything else that keys off a server being up. Signed-off-by: valgulnecron <39313199+ValgulNecron@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readiness probe
GET /statusreturned 404 forever.lloesche/valheim-serverserves its status endpoint at/status.json.Observed on the test cluster: the server was healthy with the world loaded for 3h50m while the probe failed 1008 times. Valheim would never be marked Ready.
That matters beyond cosmetics — readiness gates the graceful-stop wait (the operator holds the pod up until the game goes not-ready) and anything else keyed off a server actually being up.