Repository navigation
fix(web): match mobile server cards to the DWztv design - #711
Merged
Merged
Conversation
The design.pen regroup (#702) re-exported DWztv with the status badge and metric pills as component instances: a 17px pill-shaped badge and 28px pills. The app still drew a 24px square-cornered badge, 31px pills, a card shadow and a lighter address line, which pushed the visual diff for DWztv to 4.12% (max 4%) on master. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 30 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CI Report - 5f5aa4arun 38954314461 - attempt 1 0 failed - 10 passed - 23 skipped - 21m17s elapsed Coverage
Changed
Slowest jobs
e2e buckets run
|
ValgulNecron
pushed a commit
that referenced
this pull request
Oct 16, 2026
Brings in #711 (mobile server cards match the DWztv design). Conflict in web/src/routes/Servers.tsx: kept master's text-muted address class and this branch's hover titles (T100). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: master's "design vs browser visual diff" check fails on DWztv (Mobile Servers, Light) with 4.12% global diff against the 4.00% max. The #702 design.pen regroup re-exported DWztv with component instances: a 17px pill-shaped status badge and 28px metric pills. The app still drew a 24px badge with 4px corners, 31px pills, a card drop shadow and a lighter address line.
After: the mobile server card matches the exported design. The badge is a 17px full pill, the pills are 28px tall, the card has no shadow and the address uses
text-muted, as in the design.Same capture, same reference, same script: DWztv scored 1.55% against the pre-#702 export and 3.67% against the new one under pixelmatch 7, and 4.12% under pixelmatch 8 (#648). So the regroup caused most of the drift, and pixelmatch 8's stricter OKLab metric tipped it over.
How: four className changes in
ServerCard/StatChipinweb/src/routes/Servers.tsx(shadow-none;text-mutedon the address;leading-[13px] rounded-fullon thePhaseChip, whererounded-fullopts out of the global 4px.chipradius pin;py-[5px] leading-4on the pills). No threshold, test or design file changes. Remaining known drift, not touched here: icon set (lucide vs Material Symbols), game tile tints and the Asleep violet, which are shared app-wide styles.🤖 Generated with Claude Code
Generated by Claude Code