Repository navigation
fix(registry): scope CurseForge browse to the template's own game - #156
Merged
Merged
Conversation
The module-signing private key lives at the repo root during a signing run. It was never committed, but nothing stopped an `git add -A` from doing so. Ignore it so it cannot be staged by accident. Signed-off-by: valgulnecron <39313199+ValgulNecron@users.noreply.github.com>
The CurseForge provider hardcoded gameId=432 (Minecraft) on every search, so ARK's mods browser listed Minecraft mods. Verified against the live CurseForge API with the configured key: gameId 432 returns Minecraft content, gameId 83374 returns real ARK mods. 83374 is ARK: Survival Ascended's id from CurseForge's own /v1/games (slug ark-survival-ascended), not a guess. Templates now declare curseforgeGameID, required by CEL when provider is curseforge — there is no safe default, and defaulting is what produced the bug. classId filtering (6=mods, 4471=modpacks) stays gated on Minecraft, since CurseForge class ids are per-game taxonomy and applying Minecraft's to another game silently returns nothing. Refs: rule 7 (codegen committed with the type change). Signed-off-by: valgulnecron <39313199+ValgulNecron@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
ARK's mods browser listed Minecraft mods. The CurseForge engine hardcoded
gameId=432(Minecraft) on every search, so every game that selected thecurseforgeprovider got Minecraft's catalog.Reproduced against the live CurseForge API with the configured key:
83374is ARK: Survival Ascended's id from CurseForge's own/v1/games(slugark-survival-ascended) — looked up, not guessed.The fix
Templates declare
curseforgeGameID, required by CEL whenprovider: curseforge. There is deliberately no default: defaulting to Minecraft is precisely what caused this, and a wrong-but-plausible default fails silently (a browser full of the wrong game's mods) rather than loudly.classIdfiltering (6=mods, 4471=modpacks) stays gated on Minecraft — CurseForge class ids are per-game taxonomy, so applying Minecraft's to another game returns nothing at all.Companion
Module templates carry the ids: ValgulNecron/gameplane-module#32 (minecraft-java 432, ark 83374).
🤖 Generated with Claude Code