Skip to content

glx/xlib: count the alpha channel in GLX_BUFFER_SIZE (Tomb Raider I-III under gamescope) #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
utkarshdalal merged 1 commit into from
Nov 4, 2026
Merged

glx/xlib: count the alpha channel in GLX_BUFFER_SIZE (Tomb Raider I-III under gamescope) #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/gallium/frontends/glx/xlib/glx_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1510,7 +1510,17 @@ get_config( XMesaVisual xmvis, int attrib, int *value, GLboolean fbconfig )
*value = (int) True;
return 0;
case GLX_BUFFER_SIZE:
*value = xmvis->visinfo->depth;
/* The X visual's depth only counts the planes the server stores.
* When the visual carries an alpha channel on top of those planes
* (an 8/8/8/8 config on a depth-24 TrueColor visual), count it the
* way a DRI GLX fbconfig does, so GLX_BUFFER_SIZE is 32 and not 24:
* Windows apps ask wglChoosePixelFormatARB for 32 colour bits. */
*value = xmvis->visinfo->depth;
if (xmvis->mesa_visual.alphaBits > 0 &&
xmvis->visinfo->depth <= xmvis->mesa_visual.redBits +
xmvis->mesa_visual.greenBits +
xmvis->mesa_visual.blueBits)
*value += xmvis->mesa_visual.alphaBits;
return 0;
case GLX_LEVEL:
*value = 0;
Expand Down
Loading