Skip to content

wrapper: preserve mutable format for emulated BC texture views #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
butilly wants to merge 1 commit into
base: wrapper-25
Choose a base branch
from
Open

wrapper: preserve mutable format for emulated BC texture views #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/vulkan/wrapper/wrapper_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2023,8 +2023,10 @@ wrapper_CreateImage(VkDevice _device,
if (is_emulated_bcn(device->physical, pCreateInfo->format)) {
wrapper_bcn_gpu_storage_check(device, pCreateInfo->format);
create_info.format = get_format_for_bcn(pCreateInfo->format);
if (create_info.flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT)
create_info.flags &= ~VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT;
/* Typeless BC textures need both UNORM and SRGB views. Their backing
* formats remain a compatible pair after decoding or ASTC transcoding,
* so retain MUTABLE_FORMAT along with the translated view format list.
* Clearing it makes the alternate view invalid on the host driver. */

if (wrapper_diag_on())
wrapper_diag_append(
Expand Down
Loading