Skip to content

wrapper: gate maintenance4 memory queries on base driver support #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
butilly wants to merge 1 commit into
base: wrapper-25
Choose a base branch
from
Open

wrapper: gate maintenance4 memory queries on base driver support #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/vulkan/wrapper/wrapper_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1604,6 +1604,19 @@ if (pdf2 && pdf2->features.f) { \
physical_device->instance->dispatch_handle, "vkGetDeviceProcAddr");
vk_device_dispatch_table_load(&device->dispatch_table, gdpa,
device->dispatch_handle);

/* Android's loader can return non-NULL core command trampolines even when
* the base ICD does not implement maintenance4. Do not call those stubs
* merely because we expose Vulkan 1.3: select the existing memory-query
* fallbacks using the base feature snapshot, before wrapper emulation.
*/
if (!physical_device->base_supported_features.maintenance4) {
device->dispatch_table.GetDeviceBufferMemoryRequirements = NULL;
device->dispatch_table.GetDeviceImageMemoryRequirements = NULL;
device->dispatch_table.GetDeviceImageSparseMemoryRequirements = NULL;
WRAPPER_LOG(info, "Using maintenance4 memory-query fallbacks: base feature unavailable");
}

if (physical_device->emulate_vulkan13)
wrapper_lower_missing_commands(device);

Expand Down
Loading