Skip to content

wrapper: preserve native Mali subgroup capabilities #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
butilly wants to merge 2 commits into
base: wrapper-25
Choose a base branch
from
Open

wrapper: preserve native Mali subgroup capabilities #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9163f1a
wrapper: lower Sinking Star Mali buffer requirements queries
butilly Oct 28, 2026
3b2e103
wrapper: preserve native Mali subgroup capabilities
butilly Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/vulkan/wrapper/wrapper_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2147,7 +2147,18 @@ wrapper_GetDeviceBufferMemoryRequirements(VkDevice _device,
{
VK_FROM_HANDLE(wrapper_device, device, _device);

if (device->dispatch_table.GetDeviceBufferMemoryRequirements) {
/* Order of the Sinking Star faults in the Mali driver's maintenance4
* buffer query during D3D device initialization. Use the existing
* create/query/destroy lowering for this application, even when the
* driver exports the direct entry point. No memory is bound or allocated.
*/
const char *app_name = device->physical->instance->vk.app_info.app_name;
const bool mali_sinking_star =
device->physical->driver_properties.driverID == VK_DRIVER_ID_ARM_PROPRIETARY &&
app_name && !strcmp(app_name, "sinking_star.exe");

if (device->dispatch_table.GetDeviceBufferMemoryRequirements &&
!mali_sinking_star) {
device->dispatch_table.GetDeviceBufferMemoryRequirements(device->dispatch_handle,
pInfo, pMemoryRequirements);
return;
Expand Down
8 changes: 8 additions & 0 deletions src/vulkan/wrapper/wrapper_physical_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,6 +967,10 @@ wrapper_GetPhysicalDeviceProperties2(VkPhysicalDevice physicalDevice,
}
case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_1_1_PROPERTIES:
{
/* Keep Mali's native subgroup capabilities. Clearing these masks
* prevents vkd3d from exposing WaveOps and shader model 6.0+. */
if (pdevice->driver_properties.driverID == VK_DRIVER_ID_ARM_PROPRIETARY)
break;
VkPhysicalDeviceVulkan11Properties *vk11_prop =
(VkPhysicalDeviceVulkan11Properties *)prop;
vk11_prop->subgroupSupportedOperations = 0;
Expand Down Expand Up @@ -1033,6 +1037,10 @@ wrapper_GetPhysicalDeviceProperties2(VkPhysicalDevice physicalDevice,
}
case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_SUBGROUP_PROPERTIES:
{
/* Match the Vulkan 1.1 aggregate query: preserve the driver's
* supported operations and stages, without inventing capabilities. */
if (pdevice->driver_properties.driverID == VK_DRIVER_ID_ARM_PROPRIETARY)
break;
VkPhysicalDeviceSubgroupProperties *subgroup_prop =
(VkPhysicalDeviceSubgroupProperties *)prop;
subgroup_prop->supportedOperations = 0;
Expand Down
Loading