[joshuatam]

What this does

The payload's freshness guard compared mtimes: it failed if any file under an artifact's crates was newer than the artifact. Ages answer the wrong question, and they did so in both directions on the same day.

False positive, which is what started this. A branch switch rewrote modules/gndrm-android/Cargo.toml and modules/gndrm-daemon/Cargo.toml with byte-identical content, so they were newer than libgamenative_drm.so; cargo compares content hashes, correctly reported everything fresh, and left the artifact from three days earlier. The guard called it stale — and rerunning the package could never clear it, because nothing rewrites an artifact that cargo considers current:

error: …/libgamenative_drm.so is older than …/modules/gndrm-android/Cargo.toml

False negative, which is worse and silent. If a builder did not rewrite an artifact — because it failed, or skipped one — the old artifact was newer than the sources, so the guard passed and the payload carried it. A failed build-android.sh was not even checked: its exit code was ignored.

Change

The artifacts are always built by the run that packages them:

• the Rust side is forced to recompile by touching the workspace's own *.rs and Cargo.toml — third-party crates stay cached, which holds this to ~53 s; the C shim and the C++ engine rebuild unconditionally anyway;
• each builder's exit code is checked (build-lsfg.sh, build-shim.sh, build-android.sh);
• every shipped artifact (libgndrm_shim.so, libgamenative_drm.so, libadrenotools_gamescope.so, liblsfg_engine.so) must be newer than a mark taken before the builders ran.

That is the only claim the guard has to make: the payload carries what this run built. check_fresh and its per-artifact source lists are gone.

Cost: a package run goes from ~60 s to ~111 s on a warm tree (measured; 53 s of it the forced drm rebuild).

Verified

case	before	after
identical content, newer mtime (the report)	fails, unclearable	packages, exit 0
syntax error in gndrm-uapi/src/lib.rs	packages the previous artifact	exit 1, error: build-android.sh failed
restored source	—	packages, exit 0

File

android/package-gamescope.sh only — the builder invocations, the freshness guard, and the artifact checks.