Skip to content

Shim waits for the panel to release a buffer before the guest renders into it #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
utkarshdalal wants to merge 2 commits into
base: master
Choose a base branch
from
+763 −33
Open

Shim waits for the panel to release a buffer before the guest renders into it #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e79a84
daemon+shim: wait for the panel to release a buffer before the guest …
Nov 7, 2026
77c581d
uapi: name SurfaceFlinger as code in the release note's docs
Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions icd_shim/src/proxy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2833,6 +2833,22 @@ unsafe fn gn_acquire_common(
VK_TIMEOUT
};
}
// The slot is ours, but the panel may still be scanning its buffer out: the
// compositor hands a buffer back at the flip event, which leaves when its
// replacement is published, before that replacement is on screen. Wait for
// the release the daemon forwards for it (none from an older daemon: no
// wait) before the guest may render into it. A non-blocking acquire is not
// made to block.
if timeout != 0 {
let budget = deadline.map_or(crate::scanout::RELEASE_WAIT, |dl| {
dl.saturating_duration_since(Instant::now())
.min(crate::scanout::RELEASE_WAIT)
});
crate::scanout::wait_release(
unsafe { (*(*sc).slots.as_ptr().add(idx as usize)).ino },
budget,
);
}
if sem != 0 || fence != 0 {
let gq = unsafe { (*gd).queues };
if gq.is_null() {
Expand Down
Loading