add installs + cards#92
Open
sriharivishnu wants to merge 1 commit into
Open
Conversation
mattbaseball
requested changes
Aug 8, 2020
Contributor
mattbaseball
left a comment
mattbaseball
left a comment
There was a problem hiding this comment.
I think you should move the number of cards and the icon for that farther to the left. This makes the pack preview screen a little more symmetrical. Also, when clicking on a pack that you've already installed in the shop, the game points icon is still there as well (with no text which makes it look a little strange).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the card pack details page to show number of installs, and amount of cards a pack has.
Button is also greyed out if user clicks on a pre owned pack.