fix(consensus): validate block retrieval responses - #798
Draft
Lchangliang wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
response.verify()LedgerInfosignature / epoch checks while allowing the known epoch-change suffix block-number mismatchWhy
gravity-sdk#793temporarily disabled retrievedLedgerInfoverification to avoid rejecting valid epoch-change suffix responses. That also removed the signature check and left malformed successful responses able to reachexpect/assertsites in catch-up. This PR keeps the epoch-boundary compatibility while restoring the network-facing validation and making the consumer path fail with errors instead of panics.Tests
cargo +nightly fmt --all -- --checkRUSTFLAGS="--cfg tokio_unstable -D warnings" cargo check -p "path+file:///Users/lightman/repos/gravity-sdk/aptos-core/consensus#aptos-consensus@0.1.0" --libRUSTFLAGS="--cfg tokio_unstable" cargo test -p "path+file:///Users/lightman/repos/gravity-sdk/aptos-core/consensus/consensus-types#aptos-consensus-types@0.1.0" verify_rejects_empty_successful_responsegit diff --cached --checkAudit coverage