chore(consensus): downgrade per-vote/per-block commit-pipeline logs to debug - #759
Open
Richard1048576 wants to merge 1 commit into
Open
chore(consensus): downgrade per-vote/per-block commit-pipeline logs to debug#759Richard1048576 wants to merge 1 commit into
Richard1048576 wants to merge 1 commit into
Conversation
…o debug
The commit-vote pipeline in buffer_manager/buffer_item logs at info!/warn! for
every commit vote and every per-block pipeline step. Measured on mainnet core-1
these are the bulk of the consensus log volume:
- info! "Receive commit vote ... from ..." ~112k lines/hour (per vote)
- warn! "... does not have enough commit voting power" ~80k lines/hour (per vote)
They fire on the normal happy path: a "not enough voting power" warn! is just the
expected pre-quorum state (the is_ok() branch that reaches quorum already logs at
debug!), and the per-vote/per-block cursor advances are internal mechanics, not
operator-facing events. Together ~190k lines/hour (~17% of the node's logs), they
bury real warnings and inflate log cost. Downgrade to debug!:
buffer_item.rs warn! -> debug! (3x "... does not have enough ... voting power")
buffer_manager.rs info! -> debug! (Advance execution/signing root, Advance head,
Receive executed/signing response, Receive
commit vote, Start reliable broadcast)
Kept at info!: "Receive reset" (epoch reset) and "Receive commit decision" (commit
certificate) — low-volume, meaningful events; block commits are still logged at the
state-computer level. Pure log-level change, no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit-vote pipeline (
buffer_manager/buffer_item) logs atinfo!/warn!for every commit vote and every per-block pipeline step. Measured on mainnet core-1, these dominate the consensus log volume:Receive commit vote ... from ...info!... does not have enough commit voting power(×3)warn!That's ~190k lines/hour (~17% of the node's ~1.1M lines/hour) of pure happy-path noise. A
TooLittleVotingPowerwarn!is just the expected pre-quorum state — theis_ok()branch that actually reaches quorum already logs atdebug!— and the per-vote / per-block cursor advances are internal mechanics, not operator events. AtINFOthey bury real warnings and inflate log cost.Change (pure log-level, no behavior change)
buffer_item.rs:warn!→debug!×3 —Commit vote signatures do not have enough voting power after execution,Signed buffer item does not have enough commit voting power,Executed buffer item does not have enough commit voting power.buffer_manager.rs:info!→debug!×7 —Advance execution root,Advance signing root,Advance head,Receive executed response,Receive signing response,Receive commit vote,Start reliable broadcast … commit votes.Kept at
info!(low-volume, meaningful)Receive reset(epoch reset) andReceive commit decision(commit certificate). Actual block commits remain logged at the state-computer level.