Skip to content

fix(evm): stabilize skipped transaction reason encoding #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AshinGau merged 1 commit into from
Jul 28, 2026
Merged

fix(evm): stabilize skipped transaction reason encoding #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,6 @@ parity-scale-codec = "3.2.1"
parking_lot = "0.12"
quanta = "0.12"
paste = "1.0"
postcard = { version = "1.1.3", default-features = false, features = ["alloc"] }
rand = "0.9"
rayon = "1.7"
thread-priority = "3.0.0"
Expand Down
4 changes: 1 addition & 3 deletions crates/ethereum/evm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ reth-chainspec.workspace = true
reth-ethereum-forks.workspace = true
reth-primitives-traits.workspace = true
reth-ethereum-primitives.workspace = true
revm = { workspace = true, features = ["optional_balance_check", "optional_no_base_fee", "serde"] }
revm = { workspace = true, features = ["optional_balance_check", "optional_no_base_fee"] }
reth-evm.workspace = true
grevm.workspace = true
gravity-primitives.workspace = true
Expand All @@ -37,7 +37,6 @@ alloy-sol-types.workspace = true
# Misc
parking_lot = { workspace = true, optional = true }
derive_more = { workspace = true, optional = true }
postcard.workspace = true
tracing.workspace = true

[dev-dependencies]
Expand Down Expand Up @@ -66,7 +65,6 @@ std = [
"derive_more?/std",
"alloy-rpc-types-engine/std",
"alloy-sol-types/std",
"postcard/use-std",
"reth-storage-errors/std",
"tracing/std",
]
Expand Down
15 changes: 6 additions & 9 deletions crates/ethereum/evm/src/parallel_execute.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,17 +195,14 @@ where
tx_index,
?tx_hash,
?reason,
?error,
"included transaction skipped during final execution",
);
let receipt =
GravityTxSkippedEvent::receipt(tx_type, cumulative_gas_used, &error);
let receipt = receipt.map_err(|encode_error| {
let message = alloc::format!(
"failed to encode skipped transaction {tx_index}: {encode_error}"
);
BlockExecutionError::msg(message)
})?;
receipts.push(receipt);
receipts.push(GravityTxSkippedEvent::receipt(
tx_type,
cumulative_gas_used,
reason,
));
}
}
}
Expand Down
Loading
Loading