Skip to content

Adjust the BEC Maxwell Gate API to align with its improvements. - #221

Merged
boubou19 merged 4 commits into
GTNewHorizons:masterfrom
hxync:master
Sep 4, 2026
Merged

Adjust the BEC Maxwell Gate API to align with its improvements.#221
boubou19 merged 4 commits into
GTNewHorizons:masterfrom
hxync:master

Conversation

@hxync

@hxync hxync commented Sep 3, 2026

Copy link
Copy Markdown

Summary

In the commit on August 27 for GT5U, the Maxwell Gate was improved to have multiple filter slots. This commit introduced the @OCMethod-annotated interfaces getCondensateFilterAt and setCondensateFilterAt. However, the original OpenComputers driver still called the single-filter interface, making it impossible to access the other filter slots through OpenComputers.

This PR adds getCondensateFilterAt and setCondensateFilterAt to the OpenComputers callbacks. Additionally, since the original methods getCondensateFilter and setCondensateFilter are redundant with the new methods, they have been removed.

Checklist

  • I have tested this PR in DevEnv
  • I have tested this PR in Fullpack
  • This PR is in compliance with the GTNH AI Policy
  • This PR requires another PR in order to merge

Comment thread src/main/scala/li/cil/oc/integration/gregtech/DriverBECDiode.java
@hxync
hxync requested a review from hinyb September 4, 2026 05:56

@hinyb hinyb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@boubou19
boubou19 merged commit 18c66d3 into GTNewHorizons:master Sep 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants