Fix fluid icons rendering cropped when sprites are padded - #161
Open
Eldrinn-Elantey wants to merge 1 commit into
Open
Fix fluid icons rendering cropped when sprites are padded#161Eldrinn-Elantey wants to merge 1 commit into
Eldrinn-Elantey wants to merge 1 commit into
Conversation
Eldrinn-Elantey
added
the
Bug Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fluid textures were tiled using the sprite resolution as the tile size. When the block atlas is loaded with padding, which Angelica does by default for its RGSS texture filtering, the sprite reports twice its logical size while the UV range still covers the visible area, so only the top left quarter of the icon was drawn. The same happened with hd resource packs.
The tile size is now a fixed 16 gui pixels, which is independent of the sprite resolution, so tall tanks keep tiling the icon as before.
Reproduction: Angelica installed with Texture Filtering set to RGSS, open any gui with a fluid slot, for example Super Tank I (Супер резервуар I) in GregTech.
https://discord.com/channels/181078474394566657/522098956491030558/1539008537043148910
Checklist