Skip to content

Fix GL leaks #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dream-Master merged 1 commit into from
Jul 27, 2026
Merged

Fix GL leaks #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/gtnh/findit/fx/ParticlePosition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,14 @@ public void renderParticle(final Tessellator tessellator, float partialTickTime,
float rotationYZ, float rotationXY, float rotationXZ) {
tessellator.draw();

GL11.glPushAttrib(GL11.GL_ENABLE_BIT);
GL11.glDisable(GL11.GL_DEPTH_TEST);

tessellator.startDrawingQuads();
super.renderParticle(tessellator, partialTickTime, rotationX, rotationZ, rotationYZ, rotationXY, rotationXZ);
tessellator.draw();

GL11.glEnable(GL11.GL_DEPTH_TEST);
GL11.glPopAttrib();
tessellator.startDrawingQuads();
}

Expand Down
13 changes: 6 additions & 7 deletions src/main/java/com/gtnh/findit/fx/SlotHighlighter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,11 @@ public void renderSlotOverlay(GuiContainer gui, Slot slot) {}
@Override
public void renderSlotUnderlay(GuiContainer gui, Slot slot) {
if (this.gui == gui && this.slots.contains(slot)) {
GL11.glPushMatrix();
GL11.glPushAttrib(
GL11.GL_ENABLE_BIT | GL11.GL_COLOR_BUFFER_BIT
| GL11.GL_CURRENT_BIT
| GL11.GL_LIGHTING_BIT
| GL11.GL_TEXTURE_BIT);

GL11.glDisable(GL11.GL_LIGHTING);
GL11.glDisable(GL11.GL_ALPHA_TEST);
Expand All @@ -71,12 +75,7 @@ public void renderSlotUnderlay(GuiContainer gui, Slot slot) {
highlightSlot(tessellator, slot.xDisplayPosition, slot.yDisplayPosition);
tessellator.draw();

GL11.glShadeModel(GL11.GL_FLAT);
GL11.glDisable(GL11.GL_BLEND);
GL11.glEnable(GL11.GL_ALPHA_TEST);
GL11.glEnable(GL11.GL_LIGHTING);

GL11.glPopMatrix();
GL11.glPopAttrib();
}
}

Expand Down