Skip to content

Fix block interaction outside vanilla height limits - #118

Open
Jakfut wants to merge 4 commits into
GTNewHorizons:masterfrom
Jakfut:fix-full-height-block-interaction
Open

Fix block interaction outside vanilla height limits#118
Jakfut wants to merge 4 commits into
GTNewHorizons:masterfrom
Jakfut:fix-full-height-block-interaction

Conversation

@Jakfut

@Jakfut Jakfut commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

C07PacketPlayerDigging and C08PacketPlayerBlockPlacement Y values were serialized as unsigned byte, causing beaking/placing blocks outside of 0...255 to not work on dedicated servers

@Jakfut

Jakfut commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

fixes #117

@DarkShadow44

Copy link
Copy Markdown
Collaborator

Good catch, unfortunately this only happens in MP - in SP serialization is not used, the packages are passed directly as objects. Very annoying.

That said, there is more packets like S28PacketEffect, S0APacketUseBed and probably a bunch more.

Code looks fine for me, do you want to add the other packages as well or merge it as-is?

@Jakfut

Jakfut commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

S28PacketEffect was fixed in #119
S0APacketUseBed is weird, its a signed byte for whatever reason, sleeping worked fine at -10, +110 and +130 and I did not see any visual bugs either, so I guess its fine?

@DarkShadow44

Copy link
Copy Markdown
Collaborator

S28PacketEffect was fixed in #119 S0APacketUseBed is weird, its a signed byte for whatever reason, sleeping worked fine at -10, +110 and +130 and I did not see any visual bugs either, so I guess its fine?

I'll look into it when I find time, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants