Fix client height bounds - #116
Merged
RecursivePineapple merged 4 commits intoAug 22, 2026
Merged
Conversation
Collaborator
|
Huh did we really never handle dimension transitions? Looks good to me. |
RecursivePineapple
left a comment
RecursivePineapple
left a comment
Collaborator
There was a problem hiding this comment.
Looks good for the most part. I have two minor concerns.
|
|
||
| @Inject(method = "readPacketData", at = @At("TAIL")) | ||
| private void cubicChunks$readHeightInfo(PacketBuffer data, CallbackInfo ci) { | ||
| if (data.readableBytes() < 16) return; |
Collaborator
There was a problem hiding this comment.
This is fragile, if there's a buffer underrun because of a mixin conflict we should just crash
| @Expression("this.clientWorldController.isRemote = true") | ||
| @Inject(method = "handleRespawn", at = @At("MIXINEXTRAS:EXPRESSION")) | ||
| void initRespawnedClientCubicWorld(S07PacketRespawn packetIn, CallbackInfo ci) { | ||
| if (packetIn instanceof ICubicRespawnPacket cubicRespawnPacket) { |
Collaborator
There was a problem hiding this comment.
This instanceof should just be a cast, we don't want this silently breaking if someone removes the mixin (or breaks it by accident)
RecursivePineapple
added
the
Merge Into Prerelease
RecursivePineapple
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110 by not treating positions outside the configured world bounds as unloaded terrain, which caused the client to permanently apply the vanilla missing-chunk fall speed clamp.
Also syncs world and generation height bounds through S07PacketRespawn. Previously respawning would cause dimensions to be 0...256 on the client side until relogging