Fix issue75 population height - #105
Merged
RecursivePineapple merged 3 commits intoAug 4, 2026
Merged
Conversation
RecursivePineapple
left a comment
RecursivePineapple
left a comment
Collaborator
There was a problem hiding this comment.
Is the problem that generated cubes aren't present in storageArrays? Because if so, that should be fixed too.
Contributor
Author
|
No, the problem is that population can query terrain whose surface cube is not loaded/generated yet, so there is no surface cube to put into storageArrays yet |
RecursivePineapple
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75 by generating the required 2x2 terrain columns before legacy population and making getTopFilledSegment cube-aware.
Most of the misplaced houses seem to have been from the broken 2x2 terrain column generation, once I fixed that there was only one bugged house in 100 villages and with cube-aware getTopFilledSegment that should also be fixed, tho its hard to verify because it was so rare.
Tested with 0.1.13 alpha-pre, but should also work with 0.1.10 and without #97