Skip to content

Stops zinc gravel from showing as though it's a valid aluminium sub-soil. - #214

Draft
C0bra5 wants to merge 12 commits into
masterfrom
alu-gravel-b-gone
Draft

Stops zinc gravel from showing as though it's a valid aluminium sub-soil.#214
C0bra5 wants to merge 12 commits into
masterfrom
alu-gravel-b-gone

Conversation

@C0bra5

@C0bra5 C0bra5 commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

This PR fixes a long-standing issue where NEI sometimes shows zinc gravel as a valid sub-soil for aluminium crops. This is because aluminium gravel somehow gets hit by postea while in NEI (meaning it gets nbt serialized and deserialized).

This PR accomplishes this goal by pushing up some cleanup and optimization work I was planning for 2.10, which allows me to effectively add an NEI-only blacklist when the NH core mod is installed. If a block of alu grave still remains in the world because it didn't get migrated (somehow), or because we disabled the transformer at some point and re-added alu grave to world generation (in case we forget to also yeet the special case from cropsnh when that happens).

Checklist

  • I have tested this PR in DevEnv
  • I have tested this PR in Fullpack
    • Daily 618
  • This PR is in compliance with the GTNH AI Policy
    • No AI used

@C0bra5 C0bra5 added Bug Fix Fix a bug. Please link it in the PR. Safe for Stable Bugfix with low break chance for patch releases Refactor For PRs rewriting a part of the code to have a nicer code overall. labels Jul 12, 2026
@C0bra5 C0bra5 added Ongoing Freeze - Do NOT Merge PR tagged with this do not meet the requirement to be merged during a freeze. and removed Safe for Stable Bugfix with low break chance for patch releases labels Aug 8, 2026
@C0bra5
C0bra5 marked this pull request as draft August 8, 2026 22:01
@C0bra5

C0bra5 commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator Author

I'll throw this one back to a draft and mark it as feature-frozen because, honestly, 2.9 doesn't really need it. It would be nice to have more than anything else, and it does push some wider changes I originally planned for 2.9 that could probably be implemented better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Fix a bug. Please link it in the PR. Ongoing Freeze - Do NOT Merge PR tagged with this do not meet the requirement to be merged during a freeze. Refactor For PRs rewriting a part of the code to have a nicer code overall.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants