Fix drowning effect interval math - #147
Merged
boubou19 merged 2 commits intoAug 21, 2026
Merged
Conversation
boubou19
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two issues with the damage interval calculation for the Drowning potion effect. First of all, it fixes the issue that happens when the value of
amplifieris higher than 20: due to integer division,20 / amplifieris0, which causes a divide by zero ArithmeticException during the modulo division. Secondly, it fixes a divide by zero error when the potion amplifier is 255, caused by the byte value being interpreted as a signed byte instead of an unsigned one on half of the ticks, leading to20 / (-1 + 1)division by zero.Closes GTNewHorizons/GT-New-Horizons-Modpack#26399
Checklist