Fix bound blade not dropping blood shards if you kill in one hit - #141
Merged
Conversation
koolkrafter5
added
the
Bug Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item::hitEntity is called after LivingDropsEvent for some reason, meaning the weakness was applied after the check for it to add blood shards to the items dropped by mobs. This made it impossible to get blood shards if you killed the mob in one hit (or if you left it on low health and hit it again after the weakness ran out).
This moves the weakness effect application to LivingHurtEvent which is called before the drops are gathered. Also moves the LivingDropsEvent from its own special class to the one with all the other handlers.
Before this change:
before.mp4
After:
after.mp4