Updated mlflow to 3.11.1 for features + security#185
Merged
Conversation
+ also requests to 2.33 and torch to 2.8 in unit testing. Also bumped version to 0.10.1 to reflect this major mlflow update.
to allow the use of mlflow 3.11.1
Apparently, torch has not done +cpu since 2.4 so the correct call is 2.8.0.
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
mikewoodward94
left a comment
Collaborator
There was a problem hiding this comment.
One very minor comment!
| [options] | ||
| packages = find: | ||
| python_requires = <3.12 | ||
| python_requires = >=3.10,<3.12 |
Collaborator
There was a problem hiding this comment.
Is there a reason to restrict to just versions 3.10 and 3.11?
Collaborator
|
As discussed, there are numerous packages within setup.cfg that aren't actually necessary for csc-mlops. Could these be removed as part of this security push? |
Collaborator
Author
|
Removed packages unnecessary for csc-mlops via commit #a5a301f8c8eae1b935fb0a6de5e1b802164a304c. |
We used torch before to query if cuda exists - replaced with subprocess running nvidia-smi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This necessitates python3.10 so python versions in docker containers have also been updated to 3.10.
Also bumped version to 0.10.1 to reflect this major mlflow update.
I verified that this works on MLOps-tutorial (will also do a PR on that repo so it works with the latest version of csc-mlops).